[
https://issues.apache.org/jira/browse/WW-5870?focusedWorklogId=1056491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1056491
]
ASF GitHub Bot logged work on WW-5870:
--------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/26 10:38
Start Date: 22/Nov/26 10:38
Worklog Time Spent: 10m
Work Description: arunmanni-ai opened a new pull request, #2153:
URL: https://github.com/apache/struts/pull/2153
Two steps of the release process call wget with `--no-check-certificate`:
- the `docs` execution of the assembly module (`assembly/pom.xml`), which
mirrors the documentation from https://struts.apache.org/ into the `all` and
`docs` assemblies;
- `stage-assemblies.sh` in the `releasing-struts` skill, which fetches the
assemblies from the Nexus staging repository before they are committed to
`dist/dev`.
The option dates from 2010, when the documentation was exported from the
wiki. Both hosts present certificates that validate today, so it is no longer
needed. Removed from both calls; no CA pinning is required.
### Verification
CI runs with `-DskipAssembly`, so these checks do not exercise the changed
line in `assembly/pom.xml`.
I ran a local build without that flag and the documentation fetch completed
with certificate validation enabled. I then built the assembly module with and
without the option and compared the output: both produce an identical 356 files
across the six trees listed in `docs-urls.txt` (getting-started 51, security 1,
core-developers 172, tag-developers 97, maven-archetypes 2, plugins 33; 8.0M
total).
I had to pass `-DskipITs` for that build: the `struts2-showcase` integration
tests fail independently of this change, and the assembly module sits after
showcase in the reactor, so it is skipped otherwise.
The `stage-assemblies.sh` change is not covered by any build, since that
script runs on a release manager's machine against a live staging repository. I
confirmed separately that `repository.apache.org` presents a certificate that
validates.
Fixes [WW-5870](https://issues.apache.org/jira/browse/WW-5870)
Issue Time Tracking
-------------------
Worklog Id: (was: 1056491)
Remaining Estimate: 0h
Time Spent: 10m
> Release build: fetch the bundled documentation and the staged assemblies with
> TLS certificate validation enabled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WW-5870
> URL: https://issues.apache.org/jira/browse/WW-5870
> Project: Struts 2
> Issue Type: Improvement
> Components: Build Management
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.6.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Two steps of the release process call {{wget}} with
> {{--no-check-certificate}}:
> * the {{docs}} execution of the {{assembly}} module ({{assembly/pom.xml}}),
> which mirrors the documentation from https://struts.apache.org/ into the
> {{all}} and {{docs}} assemblies;
> * {{stage-assemblies.sh}} in the {{releasing-struts}} skill, which fetches
> the assemblies from the Nexus staging repository before they are committed to
> dist/dev.
> The option dates from 2010, when the documentation was exported from the
> wiki. Both hosts present certificates that validate today, so it is no longer
> needed.
> Proposed change:
> * remove {{--no-check-certificate}} from both calls;
> * apply the {{assembly/pom.xml}} change to the 6.x line too.
> The {{assembly}} module is built only for a release (CI runs with
> {{-DskipAssembly}}), so the change has to be checked with a local build
> without that flag.
> Reported by Arun Manni.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)