[
https://issues.apache.org/jira/browse/WW-5870?focusedWorklogId=1056493&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1056493
]
ASF GitHub Bot logged work on WW-5870:
--------------------------------------
Author: ASF GitHub Bot
Created on: 22/Nov/26 10:39
Start Date: 22/Nov/26 10:39
Worklog Time Spent: 10m
Work Description: arunmanni-ai commented on PR #2153:
URL: https://github.com/apache/struts/pull/2153#issuecomment-7077932831
One thing I noticed while verifying, not addressed here since it is outside
the scope of the ticket: the antrun `exec` in `assembly/pom.xml` has no
`failonerror`, so a wget failure for any reason leaves `target/docs` empty
while the build still reports success. `all.xml` and `docs.xml` copy that
directory into `docs/docs`, so the assemblies would ship without documentation
and nothing would flag it.
That is independent of this change, but certificate validation does add a
new way for the fetch to fail. Happy to open a ticket and a separate PR for it
if you think it is worth addressing.
Issue Time Tracking
-------------------
Worklog Id: (was: 1056493)
Time Spent: 20m (was: 10m)
> Release build: fetch the bundled documentation and the staged assemblies with
> TLS certificate validation enabled
> ----------------------------------------------------------------------------------------------------------------
>
> Key: WW-5870
> URL: https://issues.apache.org/jira/browse/WW-5870
> Project: Struts 2
> Issue Type: Improvement
> Components: Build Management
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 7.6.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Two steps of the release process call {{wget}} with
> {{--no-check-certificate}}:
> * the {{docs}} execution of the {{assembly}} module ({{assembly/pom.xml}}),
> which mirrors the documentation from https://struts.apache.org/ into the
> {{all}} and {{docs}} assemblies;
> * {{stage-assemblies.sh}} in the {{releasing-struts}} skill, which fetches
> the assemblies from the Nexus staging repository before they are committed to
> dist/dev.
> The option dates from 2010, when the documentation was exported from the
> wiki. Both hosts present certificates that validate today, so it is no longer
> needed.
> Proposed change:
> * remove {{--no-check-certificate}} from both calls;
> * apply the {{assembly/pom.xml}} change to the 6.x line too.
> The {{assembly}} module is built only for a release (CI runs with
> {{-DskipAssembly}}), so the change has to be checked with a local build
> without that flag.
> Reported by Arun Manni.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)