[
https://issues.apache.org/jira/browse/SVN-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503058#comment-17503058
]
Daniel Shahaf commented on SVN-4891:
------------------------------------
If I corrupt the text-base and have the {{if (checksum &&
svn_checksum_match(…))}} block skipped, I get the expected error:
{code}
./subversion/svn/update-cmd.c:176,
./subversion/libsvn_client/update.c:836,
./subversion/libsvn_client/update.c:722,
./subversion/libsvn_client/update.c:570,
./subversion/libsvn_wc/adm_crawler.c:869,
./subversion/libsvn_repos/reporter.c:1573,
./subversion/libsvn_repos/reporter.c:1483,
./subversion/libsvn_repos/reporter.c:1475,
./subversion/libsvn_repos/reporter.c:1413,
./subversion/libsvn_repos/reporter.c:1350,
./subversion/libsvn_repos/reporter.c:1070,
./subversion/libsvn_repos/reporter.c:737,
./subversion/libsvn_delta/text_delta.c:948,
./subversion/libsvn_wc/update_editor.c:1017:
(apr_err=SVN_ERR_WC_CORRUPT_TEXT_BASE)
svn: E155017: Checksum mismatch while updating
'/scratch/tmp.pinBTC0QWo/wc/iota':
expected: 2d18c5e57e84c5b8a5e9a6e13fa394dc
actual: f5513862004a17cb02830c92c48ff6cb
Process 3846 exited with status = 1 (0x00000001)
{code}
And {{svn status}} shows a {{{}!{}}}, as expected by the test.
> Pristines-on-demand: fix disabled tests
> ---------------------------------------
>
> Key: SVN-4891
> URL: https://issues.apache.org/jira/browse/SVN-4891
> Project: Subversion
> Issue Type: Bug
> Reporter: Julian Foad
> Assignee: Julian Foad
> Priority: Major
>
> The following tests had been changed in the pristines-on-demand development.
> Most were disabled with the '@Wimp' decorator. (This caused some of them to
> give an XPASS and some an XFAIL result when run against the older WC format,
> and all XFAIL against the newer WC format.)
> They need to be re-enabled and fixed.
> (I am removing them from this list as and when fixed.)
> {code:java}
> basic_tests.py 8 basic_commit_corruption(): basic corruption detection on
> commit
> [[Relies on wc.text_base_path()]]
> basic_tests.py 9 basic_update_corruption(): basic corruption detection on
> update
> [[Relies on wc.text_base_path()]]
> externals_tests.py ... ... ...:
> update_modify_file_external(),
> remap_file_external_with_prop_del(),
> file_external_recorded_info():
> existing issue (Windows only)
> revert_tests.py 2 revert_reexpand_keyword(): revert reexpands manually
> contracted keyword
> "See r1101730 and r1101817"
> trans_tests.py 1 keywords_from_birth(): commit new files with keywords
> active from birth
> [[Relies on wc.text_base_path()]]
> trans_tests.py 3 eol_change_is_text_mod(): committing eol-style change
> forces text send
> [[Relies on wc.text_base_path()]]
> update_tests.py 57 skip_access_denied(): access denied paths should be
> skipped
> [[Need to update the access denied handling in update_editor.c]]
> upgrade_tests.py 16 replaced_files(): upgrade with base and working
> replaced files
> [[Can't fetch pristines: the working copy points to file:///tmp/repo]]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
