[
https://issues.apache.org/jira/browse/SVN-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518078#comment-17518078
]
Julian Foad commented on SVN-4888:
----------------------------------
I have just been looking back over this issue. Clearly there is more to
it than a quick fix. Summary, based on reviewing the email thread:
- FAIL: authz_tests.py 31 remove_access_after_commit
- Patched in <https://svn.apache.org/r1898184>: in "text base sync"
phase, ignore auth error while fetching any text base; continue with
trying to fetch the rest.
- While that change fixes that particular test case, it also seems to
have regressed the failure mode of «svn cat iota@BASE» when iota is
locally-modified and has no read access. On trunk that command displayed
the base text; on this branch that command now errors out.
- We started thinking about what other failure modes could now occur
because of failures (including unauthorised, redirect, and others) at
the hydrate phase. This is somewhat open ended; we don't have a simple
answer to how this all should be taken care of consistently.
I suggest:
- revert the patch I applied, as it's papering over the problem in an
incomplete way and so possibly causes more confusion than it fixes.
- leave this issue open and come back to it later; it's an edge case not
part of common work flows.
> Pristines-on-demand: authz denied during textbase sync
> ------------------------------------------------------
>
> Key: SVN-4888
> URL: https://issues.apache.org/jira/browse/SVN-4888
> Project: Subversion
> Issue Type: Bug
> Reporter: Julian Foad
> Assignee: Julian Foad
> Priority: Major
>
> [dev@
> thread|https://lists.apache.org/thread/f3z2k4bkclqwr7zscnmjytk1239gzqz1]
> "Pristines-on-demand: authz denied during textbase sync"
> authz_tests.py 31 remove_access_after_commit(): "remove a subdir with
> authz file"
> Fails in pristine-on-demand mode in this scenario:
> - checkout
> - commit changes to files under dirs (B,D)
> - change authz in repo: remove access from (B,D)
> - local modification to file under dir (D)
> - (no text bases are present locally, yet)
> - update
> Expected: the update ...
> - removes now-inaccessible unmodified paths (B)
> - tree-conflicts now-inaccessible parent of local mods (D)
> Actual:
> - the update first does a "text base sync", trying to fetch text bases
> of all locally modified files within the tree, and
> - this code path errors out "unauthorized" when it hits a file such as (F).
> _(Annotations (B), (D), (F) refer to distinct files found in the test case.)_
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
