> On April 30, 2014, 11:52 a.m., Hyunsik Choi wrote:
> > The patch looks nice for me. You seem to go the right way. There are good
> > utilities that you can reuse. So, I leaved some comments about them. Also,
> > you explained the table schema in Jira, I'll leave additional comment about
> > the schema soon.
Those are very good comments and observation.Exactly the feedback I was looking
for :). I will fix all the issues you mentioned. There are multiple ways to do
things but for a given application there is only one right way and you have
provided me that information because I knew that in my mind this trivial binary
operation handling must already exist but I guess I was not looking in the
right places :).
Can I introduce one more partition type (COL_PART_PRED) COLUMN WITH PREDICATE
PARTITION {You can suggest the name} ??
I was thinking of utilizing existing PartitionMethodDesc java class and create
new schema for this JIRA to handle this schema
@Expose private String expression; // required
@Expose private Schema expressionSchema; // optional ==> making this
optional ==> This will not break the existing logic for COLUMN PARTITION.
@Expose private PartitionPredicateSchema; // optional ==> making this
optional ==> This will hold the new schema with COLUMN NAME,OPERAND AND VALUE
Thanks you!!!
- Alvin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20852/#review41720
-----------------------------------------------------------
On April 29, 2014, 4:15 p.m., Alvin Henrick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20852/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 4:15 p.m.)
>
>
> Review request for Tajo and Hyunsik Choi.
>
>
> Bugs: TAJO-744
> https://issues.apache.org/jira/browse/TAJO-744
>
>
> Repository: tajo
>
>
> Description
> -------
>
> TAJO-744 review request. The work is still in progress but wanted to get some
> feedback.
>
>
> Diffs
> -----
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java 4bb0ed2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java
> 67b28a2
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnValuePartition.java
> PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnValueType.java
> PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java 63ca364
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionMethodDescExpr.java
> PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionType.java
> PRE-CREATION
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
> fcaa4c3
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java
> 0b7639c
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
> 1dd33b2
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java
> aceb6f1
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java
> b2dde3d
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java
> 48a105c
> tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto 7f41596
>
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
> e6f6acc
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
> 234af19
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
> ca99160
>
> tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
> 32ea83b
> tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
> 0076794
> tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
> e7de8f6
> tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
> f2ddf13
>
> tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java
> 76a47d0
> tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 35b8ab8
> tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java
> 2010502
> tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
> 57d8b32
> tajo-core/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java
> cecb281
>
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_add_partition_ddl.sql
> PRE-CREATION
>
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_drop_partition_ddl.sql
> PRE-CREATION
> tajo-project/pom.xml 30c721d
>
> Diff: https://reviews.apache.org/r/20852/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alvin Henrick
>
>
