> On May 27, 2014, 4:11 a.m., Hyunsik Choi wrote: > > In my environment, your latest patch causes errors. Could you check this? > > Regardless of these errors, I'll continue to review the latest patch. > > > > testJoin(org.apache.tajo.master.TestGlobalPlanner) > > testSubQuerySortAfterGroup(org.apache.tajo.master.TestGlobalPlanner) > > testSortAfterGroupBy(org.apache.tajo.master.TestGlobalPlanner) > > testSelectDistinct(org.apache.tajo.master.TestGlobalPlanner) > > testSortLimit(org.apache.tajo.master.TestGlobalPlanner) > > testComplexUnion1(org.apache.tajo.master.TestGlobalPlanner) > > testComplexUnion2(org.apache.tajo.master.TestGlobalPlanner) > > > > testSubQuerySortAfterGroupMultiBlocks2(org.apache.tajo.master.TestGlobalPlanner) > > testSubQueryGroupBy(org.apache.tajo.master.TestGlobalPlanner) > > testSubQueryGroupBy2(org.apache.tajo.master.TestGlobalPlanner) > > testTPCH_Q5(org.apache.tajo.master.TestGlobalPlanner) > > testNextBlock(org.apache.tajo.master.TestExecutionBlockCursor) > > > > Tests run: 745, Failures: 200, Errors: 189, Skipped: 0 > >
Hi Hyunsik, Sorry about invalid patch.Actually after the merge with the latest revision I forgot to run the all the test.I have resolved the issues you mentioned above. The master branch have an issue this one test is still failing even without applying the patch. Failed tests: testCastFromTable(org.apache.tajo.engine.eval.TestSQLExpression): select col1::timestamp as t1, col2::float from table1 where t1 = '1980-04-01 01:50:01'::timestamp expected:<1980-0[3-31 10]:50:01-06> but was:<1980-0[4-01 01]:50:01-06> Do you think so my machine has some invalid older jar in the path etc which is causing this issue ??? After I get the feedback I will implement HCatalogStore and add more test cases to close the JIRA. Thanks! Warm Regards, Alvin. - Alvin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20852/#review43943 ----------------------------------------------------------- On May 26, 2014, 2:03 p.m., Alvin Henrick wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20852/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 2:03 p.m.) > > > Review request for Tajo and Hyunsik Choi. > > > Bugs: TAJO-744 > https://issues.apache.org/jira/browse/TAJO-744 > > > Repository: tajo > > > Description > ------- > > TAJO-744 review request. The work is still in progress but wanted to get some > feedback. > > > Diffs > ----- > > tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java 0f56bc2 > tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java > 67b28a2 > > tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnPredicatePartition.java > PRE-CREATION > tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java f60b571 > tajo-algebra/src/main/java/org/apache/tajo/algebra/JsonHelper.java 7d853d6 > > tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionMethodDescExpr.java > PRE-CREATION > tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionType.java > PRE-CREATION > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java > fcaa4c3 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java > 0b7639c > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java > d823f25 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > 85ea516 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicate.java > PRE-CREATION > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicateSchema.java > PRE-CREATION > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionPredicateMethodDesc.java > PRE-CREATION > tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto e70ed2b > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > 7924af1 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java > 0d22486 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java > 5de9633 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java > d6f9fc3 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java > ca99160 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java > 849afc8 > > tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods.sql > 4ad4c60 > > tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods_store.sql > PRE-CREATION > > tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods.sql > 060c4c8 > > tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods_store.sql > PRE-CREATION > > tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java > 453a54d > tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4 > 0076794 > tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java > e7de8f6 > tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlan.java > 6be0c6a > tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java > d5d2d47 > > tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java > 76a47d0 > tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 3b81ce2 > tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java > 2010502 > tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java > 57d8b32 > tajo-core/src/test/java/org/apache/tajo/engine/util/TestTupleUtil.java > cecb281 > > tajo-core/src/test/resources/queries/TestAlterTable/alter_table_add_partition_ddl.sql > PRE-CREATION > > tajo-core/src/test/resources/queries/TestAlterTable/alter_table_drop_partition_ddl.sql > PRE-CREATION > > Diff: https://reviews.apache.org/r/20852/diff/ > > > Testing > ------- > > > Thanks, > > Alvin Henrick > >
