-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20852/#review46489
-----------------------------------------------------------
In addition, the latest patch causes the following error in
TestAlterTable::testAlterTableAddPartition():
org.apache.tajo.engine.parser.SQLSyntaxError: ERROR: mismatched input '<EOF>'
expecting LOCATION
LINE 1:57 ALTER TABLE APART ADD COLUMN PARTITION (id = 1 , num = 2)
^
at org.apache.tajo.engine.parser.SQLAnalyzer.parse(SQLAnalyzer.java:64)
at
org.apache.tajo.QueryTestCaseBase.executeDDL(QueryTestCaseBase.java:492)
at
org.apache.tajo.QueryTestCaseBase.executeDDL(QueryTestCaseBase.java:445)
at
org.apache.tajo.engine.query.TestAlterTable.testAlterTableAddPartition(TestAlterTable.java:63)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)
- Hyunsik Choi
On May 29, 2014, 6:30 a.m., Alvin Henrick wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20852/
> -----------------------------------------------------------
>
> (Updated May 29, 2014, 6:30 a.m.)
>
>
> Review request for Tajo and Hyunsik Choi.
>
>
> Bugs: TAJO-744
> https://issues.apache.org/jira/browse/TAJO-744
>
>
> Repository: tajo
>
>
> Description
> -------
>
> TAJO-744 review request. The work is still in progress but wanted to get some
> feedback.
>
>
> Diffs
> -----
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTable.java 0f56bc2
> tajo-algebra/src/main/java/org/apache/tajo/algebra/AlterTableOpType.java
> 67b28a2
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/ColumnPredicatePartition.java
> PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java f60b571
> tajo-algebra/src/main/java/org/apache/tajo/algebra/JsonHelper.java 7d853d6
>
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionMethodDescExpr.java
> PRE-CREATION
> tajo-algebra/src/main/java/org/apache/tajo/algebra/PartitionType.java
> PRE-CREATION
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableDesc.java
> fcaa4c3
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/AlterTableType.java
> 0b7639c
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
> d823f25
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
> 85ea516
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicate.java
> PRE-CREATION
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/PartitionPredicateSchema.java
> PRE-CREATION
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionPredicateMethodDesc.java
> PRE-CREATION
> tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto e70ed2b
>
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
> 7924af1
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java
> 0d22486
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java
> 5de9633
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java
> d6f9fc3
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java
> ca99160
>
> tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java
> 849afc8
>
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods.sql
> 4ad4c60
>
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/derby/partition_methods_store.sql
> PRE-CREATION
>
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods.sql
> 060c4c8
>
> tajo-catalog/tajo-catalog-server/src/main/resources/schemas/mysql/partition_methods_store.sql
> PRE-CREATION
>
> tajo-catalog/tajo-catalog-server/src/test/java/org/apache/tajo/catalog/TestCatalog.java
> 453a54d
> tajo-core/src/main/antlr4/org/apache/tajo/engine/parser/SQLParser.g4
> 0076794
> tajo-core/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
> e7de8f6
> tajo-core/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
> 0780d4f
>
> tajo-core/src/main/java/org/apache/tajo/engine/planner/logical/AlterTableNode.java
> 76a47d0
> tajo-core/src/main/java/org/apache/tajo/master/GlobalEngine.java 3b81ce2
> tajo-core/src/test/java/org/apache/tajo/engine/parser/TestSQLAnalyzer.java
> 2010502
> tajo-core/src/test/java/org/apache/tajo/engine/query/TestAlterTable.java
> 57d8b32
>
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_add_partition_ddl.sql
> PRE-CREATION
>
> tajo-core/src/test/resources/queries/TestAlterTable/alter_table_drop_partition_ddl.sql
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20852/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alvin Henrick
>
>
