[
https://issues.apache.org/jira/browse/TAJO-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386700#comment-14386700
]
ASF GitHub Bot commented on TAJO-1460:
--------------------------------------
Github user babokim commented on a diff in the pull request:
https://github.com/apache/tajo/pull/474#discussion_r27389998
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/ExternalSortExec.java
---
@@ -630,19 +636,43 @@ public TableStats getInputStats() {
CLOSED
}
+ private static class SimpleMerger extends PairWiseMerger {
--- End diff --
I think SimpleMerger is not proper name for this class. First time when I
saw the next code, I can understand after checking the detail code of
SimpleMerger class. How about "VectorComparePairWiseMerger".
'''
if (ComparableVector.isApplicable(sortSpecs)) {
return new SimpleMerger(inSchema, left, right, comparator);
}
return new PairWiseMerger(inSchema, left, right, comparator);
'''
> Apply TAJO-1407 to ExternalSortExec
> -----------------------------------
>
> Key: TAJO-1460
> URL: https://issues.apache.org/jira/browse/TAJO-1460
> Project: Tajo
> Issue Type: Improvement
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
>
> Tipped by @Hyoungjun Kim. Seemed possible to apply easily.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
