[ 
https://issues.apache.org/jira/browse/TAJO-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390381#comment-14390381
 ] 

ASF GitHub Bot commented on TAJO-1460:
--------------------------------------

Github user babokim commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/474#discussion_r27559986
  
    --- Diff: 
tajo-core/src/test/resources/results/TestJoinBroadcast/testCrossJoinWithAsterisk1.result
 ---
    @@ -1,8 +1,8 @@
     
r_regionkey,r_name,r_comment,c_custkey,c_name,c_address,c_nationkey,c_phone,c_acctbal,c_mktsegment,c_comment
    --- End diff --
    
    @jihoonson recommend to add an order by clause to queries if necessary 
rather than just changing the order of rows of query results. I agree with this 
opinion. 
    For example, you can add 'c_custkey' column in order by clause in 
"testCrossJoinWithAsterisk1.sql".


> Apply TAJO-1407 to ExternalSortExec
> -----------------------------------
>
>                 Key: TAJO-1460
>                 URL: https://issues.apache.org/jira/browse/TAJO-1460
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>
> Tipped by @Hyoungjun Kim. Seemed possible to apply easily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to