[ 
https://issues.apache.org/jira/browse/TAJO-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648783#comment-14648783
 ] 

ASF GitHub Bot commented on TAJO-1699:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/662#discussion_r35947774
  
    --- Diff: 
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/dictionary/InfoSchemaMetadataDictionary.java
 ---
    @@ -91,7 +91,7 @@ public String getSystemDatabaseName() {
         return systemTableNames;
       }
       
    -  private TableDescriptor getTableDescriptor(String tableName) {
    +  private TableDescriptor getTableDescriptor(String tableName) throws 
UndefinedTableException {
    --- End diff --
    
    I know you just modified the function signature to throw an exception. 
However, I found a problem that this function returns null instead of throwing 
UndefinedTableException when the table of the given name is not found.
    Would you also check it please?


> Tajo Java Client version 2
> --------------------------
>
>                 Key: TAJO-1699
>                 URL: https://issues.apache.org/jira/browse/TAJO-1699
>             Project: Tajo
>          Issue Type: Improvement
>          Components: Java Client
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.11.0
>
>
> I propose Tajo Java Client version 2. Its motivations are as follows:
>  * After TAJO-1625, the error propagation has been changed significantly. 
> Java Client should make use the new error propagation system. Java Client 
> should throw the proper exceptions.
>  * Many Java API exposes internal data structure and protocol buffer data 
> structure. It requires users to understand its internal behavior and 
> architecture. We should hide them from users.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to