[
https://issues.apache.org/jira/browse/TAJO-1699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14648812#comment-14648812
]
ASF GitHub Bot commented on TAJO-1699:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/662#discussion_r35949195
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClient.java ---
@@ -133,9 +135,10 @@ TableDesc createExternalTable(final String tableName,
final Schema schema, final
* @return Table description
* @throws java.sql.SQLException
*/
- TableDesc getTableDesc(final String tableName) throws SQLException;
+ TableDesc getTableDesc(final String tableName) throws
UndefinedTableException;
- List<CatalogProtos.FunctionDescProto> getFunctions(final String
functionName) throws SQLException;
+ List<CatalogProtos.FunctionDescProto> getFunctions(final String
functionName)
+ throws AmbiguousFunctionException, UndefinedFunctionException;
--- End diff --
It would be better if ```getFunctions``` returns an empty list rather than
throwing an ```UndefinedFunctionException``` when there is no function of the
given name.
In addition, this method should return a list of the functions of the given
name. So, ```AmbiguousFunctionException``` is inappropriate.
> Tajo Java Client version 2
> --------------------------
>
> Key: TAJO-1699
> URL: https://issues.apache.org/jira/browse/TAJO-1699
> Project: Tajo
> Issue Type: Improvement
> Components: Java Client
> Reporter: Hyunsik Choi
> Assignee: Hyunsik Choi
> Fix For: 0.11.0
>
>
> I propose Tajo Java Client version 2. Its motivations are as follows:
> * After TAJO-1625, the error propagation has been changed significantly.
> Java Client should make use the new error propagation system. Java Client
> should throw the proper exceptions.
> * Many Java API exposes internal data structure and protocol buffer data
> structure. It requires users to understand its internal behavior and
> architecture. We should hide them from users.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
