Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/680#discussion_r36609654
--- Diff:
tajo-catalog/tajo-catalog-client/src/main/java/org/apache/tajo/catalog/AbstractCatalogClient.java
---
@@ -430,27 +454,32 @@ public final PartitionDescProto getPartition(final
String databaseName, final St
}
@Override
- public boolean addPartitions(String databaseName, String tableName,
List<PartitionDescProto> partitions
- , boolean ifNotExists) {
+ public void addPartitions(String databaseName, String tableName,
List<PartitionDescProto> partitions,
+ boolean ifNotExists) throws
UndefinedTableException, DuplicatePartitionException,
+ UndefinedPartitionMethodException {
--- End diff --
```UndefinedDatabaseException``` also should be handled.
In addition, ```DuplicatePartitionException``` is missed at
CatalogServer.addPartitions(). It would be great if you add it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
