Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/680#discussion_r36612232
--- Diff:
tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java ---
@@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String
tableName, final Schema schema
throw new RuntimeException(e);
}
- if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) {
- throw new DuplicateTableException(res.getState());
- }
+ throwsIfThisError(res.getState(), DuplicateTableException.class);
+ throwsIfThisError(res.getState(),
InsufficientPrivilegeException.class);
+ throwsIfThisError(res.getState(),
UnavailableTableLocationException.class);
ensureOk(res.getState());
return CatalogUtil.newTableDesc(res.getTable());
}
@Override
- public boolean dropTable(String tableName) throws
UndefinedTableException {
- return dropTable(tableName, false);
+ public void dropTable(String tableName) throws UndefinedTableException,
InsufficientPrivilegeException {
+ dropTable(tableName, false);
}
@Override
- public boolean dropTable(final String tableName, final boolean purge)
throws UndefinedTableException {
+ public void dropTable(final String tableName, final boolean purge)
+ throws UndefinedTableException, InsufficientPrivilegeException {
--- End diff --
I misunderstood some codes. Please forget this comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
