----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18112/#review34695 -----------------------------------------------------------
Ship it! +1 The latest patch looks nice for me. I leaved some trivial comments. Please handle them before you commit the patch. tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java <https://reviews.apache.org/r/18112/#comment64910> I live this part! tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java <https://reviews.apache.org/r/18112/#comment64911> Schema class implements Cloneable interface. So, it would be better to throw CloneNotSupportedException instead of catching this exception. tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java <https://reviews.apache.org/r/18112/#comment64909> It may be necessary. I would like to suggest Preconditions.checkNotNull(). It looks better and is widely used in other parts. - Hyunsik Choi On Feb. 18, 2014, 4:38 p.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18112/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2014, 4:38 p.m.) > > > Review request for Tajo. > > > Bugs: TAJO-530 > https://issues.apache.org/jira/browse/TAJO-530 > > > Repository: tajo > > > Description > ------- > > Fix warnings in tajo-catalog. > > > Diffs > ----- > > dev-support/findbugs-exclude.xml 0f967de > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > 95bd83d > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java > 084d97c > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java > e770b11 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java > f253151 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java > 5cc0de1 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java > 1b0a9fe > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java > ce42bea > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java > f7c1342 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java > d4a2c3e > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java > f8d24b0 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > f796fff > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java > 263e1dd > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java > cf13a9d > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java > 1ac9d80 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java > 8a824bd > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java > 6f1b612 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java > e9c5a03 > > Diff: https://reviews.apache.org/r/18112/diff/ > > > Testing > ------- > > mvn clean test findbugs:findbugs -Phcatalog-0.12.0 > mvn clean test findbugs:findbugs -Phcatalog-0.11.0 > > > Thanks, > > Jung JaeHwa > >
