----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18112/#review34833 -----------------------------------------------------------
tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java <https://reviews.apache.org/r/18112/#comment65209> I think that all methods of CatalogStore should throw CatalogException instead of SQLException. This is because CatalogStore is not intended to use only JDBC drivers. SQLException should be handled in concrete classes of CatalogStore. - Hyunsik Choi On Feb. 19, 2014, 11:27 a.m., Jung JaeHwa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18112/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 11:27 a.m.) > > > Review request for Tajo. > > > Bugs: TAJO-530 > https://issues.apache.org/jira/browse/TAJO-530 > > > Repository: tajo > > > Description > ------- > > Fix warnings in tajo-catalog. > > > Diffs > ----- > > dev-support/findbugs-exclude.xml 0f967de > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java > 95bd83d > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/FunctionDesc.java > 084d97c > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Options.java > e770b11 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Schema.java > f253151 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/SortSpec.java > 5cc0de1 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/TableDesc.java > 1b0a9fe > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/json/TableMetaAdapter.java > ce42bea > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionDesc.java > f7c1342 > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/partition/PartitionMethodDesc.java > d4a2c3e > > tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/statistics/StatSet.java > f8d24b0 > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java > f796fff > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStoreClientPool.java > 263e1dd > > tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java > 8310873 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/CatalogServer.java > cf13a9d > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java > 1ac9d80 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/CatalogStore.java > 8a824bd > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/DerbyStore.java > 6f1b612 > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MemStore.java > 984ba6a > > tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/MySQLStore.java > e9c5a03 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/DataChannel.java > efa1e05 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/global/GlobalPlanner.java > f390b52 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/logical/TableSubQueryNode.java > 7b88fa5 > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/physical/SeqScanExec.java > a0c0eeb > > tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/query/QueryUnitRequestImpl.java > d4006e0 > > tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/eval/ExprTestBase.java > fbfc76f > > Diff: https://reviews.apache.org/r/18112/diff/ > > > Testing > ------- > > mvn clean test findbugs:findbugs -Phcatalog-0.12.0 > mvn clean test findbugs:findbugs -Phcatalog-0.11.0 > > > Thanks, > > Jung JaeHwa > >
