[
https://issues.apache.org/jira/browse/TEZ-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095827#comment-14095827
]
Bikas Saha commented on TEZ-1390:
---------------------------------
We do not have a strong case right now except that some of the internal buffer
copies may be avoid by using a bytebuffer because it ByteString (from the
internal protobuf) allows creating a read only ByteBuffer from ByteString
without copying.
If you have any concerns then now would be a good time to voice them :)
[~ozawa] Please make sure that all getPayload() methods that return ByteBuffer
return a clone of the byte buffer as bytebuffer is not thread safe.
> Replace byte[] with ByteBuffer as the type of user payload in the API
> ---------------------------------------------------------------------
>
> Key: TEZ-1390
> URL: https://issues.apache.org/jira/browse/TEZ-1390
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Tsuyoshi OZAWA
> Priority: Blocker
> Attachments: pig.payload.txt
>
>
> This is just and API change. Internally we can continue to use byte[] since
> thats a much bigger change.
> The translation from ByteBuffer to byte[] in the API layer should not have
> perf impact.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
