[ https://issues.apache.org/jira/browse/TEZ-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099748#comment-14099748 ]
Tsuyoshi OZAWA commented on TEZ-1390: ------------------------------------- [~sseth], updated a patch. * Made UserPayload.getPayload() return a read-only buffer. * Changed to use ByteString.asReadOnlyByteBuffer in DagTypeConverter. * Made EntityDescriptor use ByteBuffer.get() to accept read-only buffers. After rebasing, the APIs(to/fromByteArray) became a to/fromUserPayload and we don't need to change them. > Replace byte[] with ByteBuffer as the type of user payload in the API > --------------------------------------------------------------------- > > Key: TEZ-1390 > URL: https://issues.apache.org/jira/browse/TEZ-1390 > Project: Apache Tez > Issue Type: Improvement > Reporter: Bikas Saha > Assignee: Tsuyoshi OZAWA > Priority: Blocker > Attachments: TEZ-1390.1.patch, TEZ-1390.2.patch, pig.payload.txt > > > This is just and API change. Internally we can continue to use byte[] since > thats a much bigger change. > The translation from ByteBuffer to byte[] in the API layer should not have > perf impact. -- This message was sent by Atlassian JIRA (v6.2#6252)