[ 
https://issues.apache.org/jira/browse/TEZ-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099796#comment-14099796
 ] 

Bikas Saha commented on TEZ-1390:
---------------------------------

Patch mostly looks good to me. There are some non test uses for the 
deepArrayCopy that should probably not be there. Also the ByteBuffer from 
byteArray from ByteString from conf might be made more efficient. 
Lastly there is the open question of whether the Event need to change 
internally to ByteBuffer instead of byte array so that they can make use of the 
0 copy byte buffer from proto.bytestring.

> Replace byte[] with ByteBuffer as the type of user payload in the API
> ---------------------------------------------------------------------
>
>                 Key: TEZ-1390
>                 URL: https://issues.apache.org/jira/browse/TEZ-1390
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Bikas Saha
>            Assignee: Tsuyoshi OZAWA
>            Priority: Blocker
>         Attachments: TEZ-1390.1.patch, TEZ-1390.2.patch, pig.payload.txt
>
>
> This is just and API change. Internally we can continue to use byte[] since 
> thats a much bigger change.
> The translation from ByteBuffer to byte[] in the API layer should not have 
> perf impact.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to