[ https://issues.apache.org/jira/browse/TEZ-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14127525#comment-14127525 ]
Hitesh Shah commented on TEZ-853: --------------------------------- Mostly looks good. Main question on the unit test. Why is job1 being compared against job2? Based on the kind of failing dag being run, should the test be able to verify how many failures and/or kills are expected? Also, totalSuccess should be calculated based on total num tasks across vertices - correct? Is there a counter for succeeded tasks - if yes, that should be verified too. > Support counters recovery > ------------------------- > > Key: TEZ-853 > URL: https://issues.apache.org/jira/browse/TEZ-853 > Project: Apache Tez > Issue Type: Sub-task > Reporter: Hitesh Shah > Assignee: Jeff Zhang > Attachments: Tez-853-2.patch, Tez-853.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)