[
https://issues.apache.org/jira/browse/TEZ-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530052#comment-14530052
]
Siddharth Seth commented on TEZ-1961:
-------------------------------------
[~zjffdu] - this may be a slightly more involved fix. Just logging is not
sufficient since that can lead to NPEs and other errors. The findbugs warning
is very relevant in this case.
The RPC layer is logging this message - which will likely happen for any
Exception. We could think of indicating NoRunningDag via a valid RPC response
(instead of throwing an exception).
getDAGStatusViaAM in DAGClientImpl or getDAGStatusViaAM in DAGClientRPCImpl
handle TezExceptions and suppress them, which is why this works (the
documentation mentions "// can be either due to a n/w issue of due to AM
completed." which is not the case here so may need to be updated).
> Remove misleading exception "No running dag" from AM logs
> ---------------------------------------------------------
>
> Key: TEZ-1961
> URL: https://issues.apache.org/jira/browse/TEZ-1961
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Priority: Critical
> Attachments: TEZ-1961-1.patch
>
>
> {code}
> 15/01/14 16:45:06 INFO ipc.Server: IPC Server handler 0 on 51000, call
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPB.getDAGStatus
> from Call#0 Retry#0
> org.apache.tez.dag.api.TezException: No running dag at present
> at
> org.apache.tez.dag.api.client.DAGClientHandler.getDAG(DAGClientHandler.java:84)
> at
> org.apache.tez.dag.api.client.DAGClientHandler.getACLManager(DAGClientHandler.java:151)
> at
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPBServerImpl.getDAGStatus(DAGClientAMProtocolBlockingPBServerImpl.java:94)
> at
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolRPC$DAGClientAMProtocol$2.callBlockingMethod(DAGClientAMProtocolRPC.java:7375)
> at
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
> at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2041)
> at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2037)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:415)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
> at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2035)
> 15/01/14 16:45:06 INFO client.DAGClientImpl: DAG initialized:
> CurrentState=Running
> {code}
> This exception shows up fairly often and isn't very relevant - queries before
> a DAG is submitted to the AM.
> This is very misleading, especially for folks new to Tez, and should be
> removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
