[ 
https://issues.apache.org/jira/browse/TEZ-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532244#comment-14532244
 ] 

Jeff Zhang commented on TEZ-1961:
---------------------------------

[~sseth] Please help review it.

* Wait for DAGAppMaster go to RUNNING/SHUTDOWN, then return DAGClient in 
non-session mode. This can ensure that dag has started to run.   [~bikassaha] 
Previously DAGClientAMProtocol#getAMStatus is not supported for non-session 
mode, is there any considering for that ? I make it supported under non-session 
mode in this patch.  
* The patch cause a little difference on the tracking URL of application. This 
is one bug of YARN which has been been solved in YARN-2246 (solved in 
hadoop-2.7)
The bug is there may be some suffix at the end of trackingURL when app move 
from SUBMITTED to RUNNING. So after this patch, the trackingURL will change 
from http://localhost:53419/proxy/application_1430963524753_0005  to 
http://localhost:53419/proxy/application_1430963524753_0005/ui/
* Still keep the null currentDAG check in DAGClientHandler as sanity check. 

> Remove misleading exception "No running dag" from AM logs
> ---------------------------------------------------------
>
>                 Key: TEZ-1961
>                 URL: https://issues.apache.org/jira/browse/TEZ-1961
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Jeff Zhang
>            Priority: Critical
>         Attachments: TEZ-1961-1.patch, TEZ-1961-2.patch, TEZ-1961-3.patch
>
>
> {code}
> 15/01/14 16:45:06 INFO ipc.Server: IPC Server handler 0 on 51000, call 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPB.getDAGStatus 
> from  Call#0 Retry#0
> org.apache.tez.dag.api.TezException: No running dag at present
>       at 
> org.apache.tez.dag.api.client.DAGClientHandler.getDAG(DAGClientHandler.java:84)
>       at 
> org.apache.tez.dag.api.client.DAGClientHandler.getACLManager(DAGClientHandler.java:151)
>       at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolBlockingPBServerImpl.getDAGStatus(DAGClientAMProtocolBlockingPBServerImpl.java:94)
>       at 
> org.apache.tez.dag.api.client.rpc.DAGClientAMProtocolRPC$DAGClientAMProtocol$2.callBlockingMethod(DAGClientAMProtocolRPC.java:7375)
>       at 
> org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:617)
>       at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2041)
>       at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2037)
>       at java.security.AccessController.doPrivileged(Native Method)
>       at javax.security.auth.Subject.doAs(Subject.java:415)
>       at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1657)
>       at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2035)
> 15/01/14 16:45:06 INFO client.DAGClientImpl: DAG initialized: 
> CurrentState=Running
> {code}
> This exception shows up fairly often and isn't very relevant - queries before 
> a DAG is submitted to the AM.
> This is very misleading, especially for folks new to Tez, and should be 
> removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to