[
https://issues.apache.org/jira/browse/TEZ-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533677#comment-14533677
]
Jeff Zhang commented on TEZ-2410:
---------------------------------
[~bikassaha] Sorry for my ugly mistake in my last patch. Upload new patch to
address issue in comments.
bq. Which test case is covered the VertexImpl change?
testVertexCommit_OnVertexSuccess()?
All the verification of VertexCommitStartedEvent cover this (Especially
testVertexCommit_OnDAGSuccess & testVertexCommit_OnVertexSuccess ). With the
change in VertexImpl, VertexCommitStartedEvent may be logged multiple times
(one time for each output)
bq. Which test/check is covering that vertexgroupcommit event is not written
for a non-group vertex when all commits happen on dag success?
testDAGCommitSucceeded_OnDAGSuccess
> VertexGroupCommitFinishedEvent & VertexCommitStartedEvent is not logged
> correctly
> ---------------------------------------------------------------------------------
>
> Key: TEZ-2410
> URL: https://issues.apache.org/jira/browse/TEZ-2410
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.7.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Priority: Blocker
> Attachments: TEZ-2410-1.patch, TEZ-2410-1.patch, TEZ-2410-2.patch,
> TEZ-2410-3.patch
>
>
> VertexGroupCommitFinishedEvent may be logged for non-vertex group commits.
> VertexGroupCommitFinishedEvent may be logged for each member vertex of the
> group instead of once per group.
> VertexCommitStartedEvent may be logged for each output of vertex
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
