[ 
https://issues.apache.org/jira/browse/TEZ-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533726#comment-14533726
 ] 

Bikas Saha commented on TEZ-2410:
---------------------------------

+1 lgtm.

Did not find any testDAGCommitSucceeded_OnDAGSuccess.
Somewhere there should be this check for vertex v1 commit on dag success, right?
historyEventHandler.verifyVertexGroupCommitFinishedEvent("v1", 0);

> VertexGroupCommitFinishedEvent & VertexCommitStartedEvent is not logged 
> correctly
> ---------------------------------------------------------------------------------
>
>                 Key: TEZ-2410
>                 URL: https://issues.apache.org/jira/browse/TEZ-2410
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>            Priority: Blocker
>         Attachments: TEZ-2410-1.patch, TEZ-2410-1.patch, TEZ-2410-2.patch, 
> TEZ-2410-3.patch
>
>
> VertexGroupCommitFinishedEvent may be logged for non-vertex group commits.
> VertexGroupCommitFinishedEvent may be logged for each member vertex of the 
> group instead of once per group.
> VertexCommitStartedEvent may be logged for each output of vertex



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to