[ 
https://issues.apache.org/jira/browse/TEZ-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558631#comment-14558631
 ] 

Rajesh Balamohan commented on TEZ-2483:
---------------------------------------

In normal cases, it would throw exception in the finally block as close() would 
have been called anyways. Even though it is harmless, it might be easier to add 
this to task.cleanup() by checking "this.state.equals(State.CLOSED)". 

lgtm otherwise.

> Tez should close task if processor fail
> ---------------------------------------
>
>                 Key: TEZ-2483
>                 URL: https://issues.apache.org/jira/browse/TEZ-2483
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Daniel Dai
>             Fix For: 0.7.1
>
>         Attachments: TEZ-2483-1.patch, TEZ-2483-2.patch
>
>
> The symptom is if PigProcessor fail, MRInput is not closed. On Windows, this 
> creates a problem since Pig client cannot remove the input file.
> In general, if a task fail, Tez shall close all input/output handles in 
> cleanup. MROutput is closed in MROutput.abort() which Pig invokes explicitly 
> right now. Attach a demo patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to