[ https://issues.apache.org/jira/browse/TEZ-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558637#comment-14558637 ]
TezQA commented on TEZ-2483: ---------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735239/TEZ-2483-2.patch against master revision 87156be. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in : org.apache.tez.runtime.task.TestTaskExecution Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/738//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/738//console This message is automatically generated. > Tez should close task if processor fail > --------------------------------------- > > Key: TEZ-2483 > URL: https://issues.apache.org/jira/browse/TEZ-2483 > Project: Apache Tez > Issue Type: Bug > Reporter: Daniel Dai > Fix For: 0.7.1 > > Attachments: TEZ-2483-1.patch, TEZ-2483-2.patch > > > The symptom is if PigProcessor fail, MRInput is not closed. On Windows, this > creates a problem since Pig client cannot remove the input file. > In general, if a task fail, Tez shall close all input/output handles in > cleanup. MROutput is closed in MROutput.abort() which Pig invokes explicitly > right now. Attach a demo patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)