[
https://issues.apache.org/jira/browse/TEZ-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654871#comment-15654871
]
TezQA commented on TEZ-3508:
----------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12838406/TEZ-3508.002.patch
against master revision a93dbf0.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 3.0.1) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-TEZ-Build/2101//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2101//console
This message is automatically generated.
> TestTaskScheduler cleanup
> -------------------------
>
> Key: TEZ-3508
> URL: https://issues.apache.org/jira/browse/TEZ-3508
> Project: Apache Tez
> Issue Type: Test
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: TEZ-3508.001.patch, TEZ-3508.002.patch
>
>
> TestTaskScheduler is very fragile, since it builds mocks of the AMRM client
> that is tied very specifically to the particulars of the way the
> YarnTaskScheduler is coded. Any variance in that often leads to test
> failures because the mocks no longer accurately reflect what the real AMRM
> client does.
> It would be much simpler and more robust to leverage the AMRMClientForTest
> and AMRMAsyncClientForTest classes in TestTaskSchedulerHelpers rather than
> maintain fragile mocks attempting to emulate the behaviors of those classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
