[
https://issues.apache.org/jira/browse/TEZ-3508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677488#comment-15677488
]
Siddharth Seth commented on TEZ-3508:
-------------------------------------
+1
> TestTaskScheduler cleanup
> -------------------------
>
> Key: TEZ-3508
> URL: https://issues.apache.org/jira/browse/TEZ-3508
> Project: Apache Tez
> Issue Type: Test
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: TEZ-3508.001.patch, TEZ-3508.002.patch,
> TEZ-3508.003.patch
>
>
> TestTaskScheduler is very fragile, since it builds mocks of the AMRM client
> that is tied very specifically to the particulars of the way the
> YarnTaskScheduler is coded. Any variance in that often leads to test
> failures because the mocks no longer accurately reflect what the real AMRM
> client does.
> It would be much simpler and more robust to leverage the AMRMClientForTest
> and AMRMAsyncClientForTest classes in TestTaskSchedulerHelpers rather than
> maintain fragile mocks attempting to emulate the behaviors of those classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
