[GitHub] [tez] abstractdog commented on a diff in pull request #212: TEZ-4038: Add a /prof profiler endpoint like HiveServer2 has

[GitBox]

abstractdog commented on code in PR #212:
URL: https://github.com/apache/tez/pull/212#discussion_r885391487


##########
tez-tests/src/test/java/org/apache/tez/test/TestAM.java:
##########
@@ -76,6 +76,12 @@ public static void setup() throws IOException {
       tezClusterConf.setInt("yarn.nodemanager.delete.debug-delay-sec", 20000);
       
tezClusterConf.setLong(TezConfiguration.TEZ_AM_SLEEP_TIME_BEFORE_EXIT_MILLIS, 
1000);
       tezClusterConf.set(YarnConfiguration.PROXY_ADDRESS, "localhost");
+      //provide temporary profiler script to test /prof end point
+      String profilerHome = System.getProperty("java.io.tmpdir");

Review Comment:
   refactor this to a method (profilerHome + profiler file), like, getProfiler



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org