[GitHub] [tez] abstractdog commented on a diff in pull request #212: TEZ-4038: Add a /prof profiler endpoint like HiveServer2 has

[GitBox]

abstractdog commented on code in PR #212:
URL: https://github.com/apache/tez/pull/212#discussion_r885392096


##########
tez-tests/src/test/java/org/apache/tez/test/TestAM.java:
##########
@@ -133,14 +144,18 @@ public void testAMWebUIService() throws TezException, 
IOException, InterruptedEx
   }
 
   private void checkAddress(String url) {
+    checkAddress(url, 200);
+  }
+
+  private void checkAddress(String url, int expectedCode) {
     boolean success = false;
     try {
       HttpURLConnection connection = (HttpURLConnection) new 
URL(url).openConnection();
       connection.connect();
-      success = (connection.getResponseCode() == 200);
+      success = (connection.getResponseCode() == expectedCode);
     } catch (Exception e) {
       LOG.error("Error while checking url: " + url, e);
     }
     assertTrue(url + " should be available", success);
   }
-}
+}

Review Comment:
   nit, new line is expected at the end of classes I guess



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@tez.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org