abstractdog commented on code in PR #365:
URL: https://github.com/apache/tez/pull/365#discussion_r1733168068
##########
tez-dag/src/main/java/org/apache/tez/dag/app/DAGAppMaster.java:
##########
@@ -1743,6 +1747,13 @@ public void setQueueName(String queueName) {
}
}
+ private String getShutdownTimeString() {
+ if (shutdownHandler != null && shutdownHandler.shutdownTime != null) {
+ return ". The shutdown hook started at " + shutdownHandler.shutdownTime;
Review Comment:
It's strange that this separate string generation method takes care of the
closing point of the previous sentence, I believe that should go back to
getApplicationACLs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
