abstractdog commented on PR #365:
URL: https://github.com/apache/tez/pull/365#issuecomment-2315011333
nit: what about changing shutdownTime to private?
not necessarily because of the checkstyle warning (private + accessor
methods), but instead to keep it inline with other fields of
DAGAppMasterShutdownHandler, like:
```
private AtomicBoolean shutdownHandled = new AtomicBoolean(false);
private long sleepTimeBeforeExit =
TezConstants.TEZ_DAG_SLEEP_TIME_BEFORE_EXIT;
```
I guess the usage scope of those are similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
