abstractdog commented on code in PR #324:
URL: https://github.com/apache/tez/pull/324#discussion_r1894849978


##########
tez-runtime-internals/src/main/java/org/apache/tez/runtime/TezThreadDumpHelper.java:
##########
@@ -70,21 +71,17 @@ private TezThreadDumpHelper(long duration, Configuration 
conf) throws IOExceptio
         "path: {}", duration, basePath);
   }
 
-  public TezThreadDumpHelper() {

Review Comment:
   hm, cannot recall what the purpose was of this constructor, does reflection 
work without this explicitly defined?
   I'm afraid that as there is private parameterized constructor, 
class.newInstance() throws an InstantiationException, doesn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to