abstractdog commented on code in PR #324:
URL: https://github.com/apache/tez/pull/324#discussion_r1894863911
##########
tez-runtime-internals/src/main/java/org/apache/tez/runtime/TezThreadDumpHelper.java:
##########
@@ -70,21 +71,17 @@ private TezThreadDumpHelper(long duration, Configuration
conf) throws IOExceptio
"path: {}", duration, basePath);
}
- public TezThreadDumpHelper() {
Review Comment:
right, I was wrong, the hooks are created by reflection, the
TezThreadDumpHelper is not
```
helper = TezThreadDumpHelper.getInstance(conf).start(id.toString());
```
##########
tez-runtime-internals/src/main/java/org/apache/tez/runtime/TezThreadDumpHelper.java:
##########
@@ -70,21 +71,17 @@ private TezThreadDumpHelper(long duration, Configuration
conf) throws IOExceptio
"path: {}", duration, basePath);
}
- public TezThreadDumpHelper() {
Review Comment:
right, I was wrong, the hooks are created by reflection, but the
TezThreadDumpHelper is not
```
helper = TezThreadDumpHelper.getInstance(conf).start(id.toString());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
