[
https://issues.apache.org/jira/browse/TEZ-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741149#comment-13741149
]
Hitesh Shah commented on TEZ-301:
---------------------------------
Comments:
- make task id final in the new event class
- no unit tests
- handling of re-scheduled tasks? Take a look at the handling of
V_TASK_RESCHEDULED event in VertexImpl.
{code}
.addTransition(TaskStateInternal.RUNNING, TaskStateInternal.RUNNING,
- TaskEventType.T_ATTEMPT_LAUNCHED) //more attempts may start later
+ TaskEventType.T_ATTEMPT_LAUNCHED, new LaunchTransition())
{code}
The above code with the changes in LaunchTransition will cause Task to send
multiple task launched events to the Vertex. Is that the intention? Wouldn't
counts be off in that case?
Please take a look at the current unit tests and see how you can augment them
to test running count in various situations. This will catch different issues
raised above.
> Running task count in DAG Progress is always 0 ( even as tasks complete ).
> --------------------------------------------------------------------------
>
> Key: TEZ-301
> URL: https://issues.apache.org/jira/browse/TEZ-301
> Project: Apache Tez
> Issue Type: Bug
> Reporter: Hitesh Shah
> Assignee: joeyli
> Labels: TEZ-0.2.0
> Attachments: TEZ-301.2.patch, TEZ-301.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
