[ 
https://issues.apache.org/jira/browse/TEZ-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918600#comment-13918600
 ] 

Siddharth Seth commented on TEZ-373:
------------------------------------

On the patch itself, looks good - not changing any public APIs. There's some 
minor stuff like unused imports in VertexManagerPlugin and elsewhere which 
should be removed, and some unnecessary changes to TestTezUtils.
[~bikassaha], up to you on the utility of making the change since you'd opened 
the initial jira.

> Create UserPayload class
> ------------------------
>
>                 Key: TEZ-373
>                 URL: https://issues.apache.org/jira/browse/TEZ-373
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Tsuyoshi OZAWA
>              Labels: newbie
>         Attachments: TEZ-373.1.patch, TEZ-373.2.patch, TEZ-373.3.patch
>
>
> Currently Tez allows user payload to be passed as byte[]. Within Tez code is 
> hard to understand where byte[] is userPayload and where is not user payload. 
> If we create a TezUserPayload class that contains byte[] as a member then its 
> much easier to search and identify in code.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to