[
https://issues.apache.org/jira/browse/TEZ-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990207#comment-13990207
]
Bikas Saha commented on TEZ-373:
--------------------------------
I dont see DAGTypeConverters in the patch. I see TezUserPayloadFactory being
used which should be replaced by DAGTypeConverters. Also, after that change I
dont think TezUserPayload will not need to be a Writable. DAGTypeConverter will
create TezUserPayload from the PB object and convert TezUserPayload into a PB
object. E.g. the following converts from EdgePlan (which is PB) to EdgeProperty
(Java internal object)
{code} public static EdgeProperty createEdgePropertyMapFromDAGPlan(EdgePlan
edge) { {code}
> Create UserPayload class
> ------------------------
>
> Key: TEZ-373
> URL: https://issues.apache.org/jira/browse/TEZ-373
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Tsuyoshi OZAWA
> Labels: newbie
> Attachments: TEZ-373.1.patch, TEZ-373.2.patch, TEZ-373.3.patch,
> TEZ-373.4.patch, TEZ-373.5.patch, TEZ-373.6.patch, TEZ-373.7.patch
>
>
> Currently Tez allows user payload to be passed as byte[]. Within Tez code is
> hard to understand where byte[] is userPayload and where is not user payload.
> If we create a TezUserPayload class that contains byte[] as a member then its
> much easier to search and identify in code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
