[
https://issues.apache.org/jira/browse/TEZ-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998882#comment-13998882
]
Bikas Saha commented on TEZ-373:
--------------------------------
Sounds reasonable. 2 comments
1) Please dont create a byte[] when the payload is null. It should remain null.
2) Once TezUserPayload is created, there should be no need to use any more
converter methods to access the payload. So TezUserPayload class should look
like
{code}class TezUserPayload {
byte[] payload;
byte[] getPayload() {return payload};
}{code}
> Create UserPayload class
> ------------------------
>
> Key: TEZ-373
> URL: https://issues.apache.org/jira/browse/TEZ-373
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Tsuyoshi OZAWA
> Labels: newbie
> Attachments: TEZ-373.1.patch, TEZ-373.2.patch, TEZ-373.3.patch,
> TEZ-373.4.patch, TEZ-373.5.patch, TEZ-373.6.patch, TEZ-373.7.patch,
> TEZ-373.8.patch, TEZ-373.9.patch
>
>
> Currently Tez allows user payload to be passed as byte[]. Within Tez code is
> hard to understand where byte[] is userPayload and where is not user payload.
> If we create a TezUserPayload class that contains byte[] as a member then its
> much easier to search and identify in code.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
