[
https://issues.apache.org/jira/browse/TEZ-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Siddharth Seth updated TEZ-1213:
--------------------------------
Attachment: TEZ-1213.1.txt
Patch makes the following changes
- All (except one) parameters are prefixed with tez.runtime.
- DEFAULT constants follow the conventions used in Tez - i.e.
<PARAMETER_NAME>_DEFAULT
- Created a set of allowed parameters
- Moves some parameters which cannot be set by users into a separate class
- Marks TezJobConfig as Public, Evolving (from Private, Evolving)
- Changes to TaskContextImpl to accept work-dirs as a parameter instead of
reading it out from Configuration.
- Adds a tez parameter for io.file.buffer.size (This is a Hadoop parameter, but
is accessed all over the code as a direct string)
[~bikassaha], [~hitesh] - quick review please. I'd like to commit this, so that
I continue on TEZ-1080 based on this patch. Unless there are some serious
issues, would prefer addressing them in a subsequent jira (TEZ-1080 itself or a
new one).
TBD:
- Rename TezJobConfig itself
- Make use of some of the config variables instead of strings (e.g.
io.file.buffer.size)
- Potentially rename some of the parameters to make more sense. e.g. There's a
bunch of 'percentage' parameters which are actually 'fractions'
- Post a list of renamed parameters in this patch.
> Fix parameter naming in TezJobConfig
> ------------------------------------
>
> Key: TEZ-1213
> URL: https://issues.apache.org/jira/browse/TEZ-1213
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1213.1.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)