[
https://issues.apache.org/jira/browse/TEZ-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038984#comment-14038984
]
Hitesh Shah commented on TEZ-1213:
----------------------------------
Comments:
- some fields in TezRuntimeFrameworkConfigs do not use TEZ_RUNTIME_PREFIX
- For io.file.buffer.size, is there a hadoop-common defined var which we can
re-use?
- There are some inconsistencies like
TEZ_RESOURCE_CALCULATOR_PROCESS_TREE_CLASS which uses tez runtime prefix but
the field name is unchanged. What var is not prefixed with tez.runtime apart
from credentials?
- Spurious comments like // KKK
bq. Utility code to generate statements to add every element to the keyset
- Shouldnt this look only at static fields and only with names prefixed with
TEZ_ and do not contain PREFIX?
- Not sure why this helper exists in the first place? It doesn't even print
out the actual and/or default values. Is it a tez developer resource or for a
user to discover all the potential keys that they can set?
bq. String basePath =
conf.get(TezRuntimeFrameworkConfigs.TASK_LOCAL_RESOURCE_DIR, ".");
- Similar to work dirs, I am guessing this should also not use conf. Do we
need a general runtime context object to be used instead of conf for all such
info? Separate jira?
- It is surprising that there are hardly any changes in
registerMRToRuntimeKeyTranslation() with respect to the re-factored names?
> Fix parameter naming in TezJobConfig
> ------------------------------------
>
> Key: TEZ-1213
> URL: https://issues.apache.org/jira/browse/TEZ-1213
> Project: Apache Tez
> Issue Type: Improvement
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Attachments: TEZ-1213.1.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
