[
https://issues.apache.org/jira/browse/TEZ-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041149#comment-14041149
]
Siddharth Seth commented on TEZ-1218:
-------------------------------------
[~zjffdu], the patch looks good to me. Can you confirm that there are no
changes other than the renames and file moves, (and the
TaskSchedulerEventHandler changes to not cast).
> Make TaskScheduler as AbstractService rather than just an interface
> -------------------------------------------------------------------
>
> Key: TEZ-1218
> URL: https://issues.apache.org/jira/browse/TEZ-1218
> Project: Apache Tez
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: Tez_1218.patch
>
>
> Currently, the TaskSchedulerInterface is just a interface. And in
> TaskSchedulerEventHandler we explicitly convert it to AbstractService to init
> and start it. This is not necessary, we could just make it as Service which
> is a very common pattern that EventHandler depends on Service just as we did
> in HistoryEventHandler that it depends on HistoryLoggingService.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
