[
https://issues.apache.org/jira/browse/TEZ-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043515#comment-14043515
]
Jeff Zhang commented on TEZ-1218:
---------------------------------
[~sseth] Thanks for your review. Besides the renames, file moves and remove
the cast , also make TaskSchedulerService extends AbstractService and add
constructor.
I guess you are trying to make these changes on your side and then commit it,
right ? It would be much easier to do it in this way, since the patch is not
based on the latest commit.
> Make TaskScheduler as AbstractService rather than just an interface
> -------------------------------------------------------------------
>
> Key: TEZ-1218
> URL: https://issues.apache.org/jira/browse/TEZ-1218
> Project: Apache Tez
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: Tez_1218.patch
>
>
> Currently, the TaskSchedulerInterface is just a interface. And in
> TaskSchedulerEventHandler we explicitly convert it to AbstractService to init
> and start it. This is not necessary, we could just make it as Service which
> is a very common pattern that EventHandler depends on Service just as we did
> in HistoryEventHandler that it depends on HistoryLoggingService.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
