[
https://issues.apache.org/jira/browse/TEZ-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050893#comment-14050893
]
Siddharth Seth commented on TEZ-692:
------------------------------------
Looks good overall, minor stuff.
- Is AMConfiguration now private, didn't see any constructor in TezClient to
use this (would be good to annotate it considering it was public in 0.4, even
though it's a package access class)
- addAppMasterLocalResources is a little unclear in non-session mode - do
resources stack across calls ?
{code}
* If app master resources/credentials are needed then this is the recommended
* constructor for session mode execution.
{code}
This exists on two constructors, which one is the preferred mode (with or
without the explicit flag for session mode) ?
> Unify job submission in either TezClient or TezSession
> ------------------------------------------------------
>
> Key: TEZ-692
> URL: https://issues.apache.org/jira/browse/TEZ-692
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: TEZ-692.1.patch, TEZ-692.2.patch, TEZ-692.3.patch,
> TEZ-692.4.patch, TEZ-692.5.patch
>
>
> Its confusing to have 2 ways to create and submit a tez job. The developer
> has to spend time thinking about and deciding which method to use.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
