[ 
https://issues.apache.org/jira/browse/TEZ-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050908#comment-14050908
 ] 

Jeff Zhang commented on TEZ-1247:
---------------------------------

Attach the patch.

[~bikassaha]  Agree that should rename verify to processDAGAndVerify to make it 
more clear. 

Several changes in the patch
* rename verify to processDAGAndVerify and remove the public. Try to remove the 
public on method createDAG, but it is called by DAGAppMaster in method 
startPreWarmContainers, so didn't do that.
* add boolean field isProcessed in DAG to make the process logic only been 
called one time. This is used for 
[TEZ-974|https://issues.apache.org/jira/browse/TEZ-974] where 
processDAGAndVerify will been called 2 times, one is when generating graphviz 
and another is when submiting DAG.  Besides, update the test case to validate 
that the processDAGAndVerify could been called multiple times

> Method verify() of DAG can't been called multiples times in some cases
> ----------------------------------------------------------------------
>
>                 Key: TEZ-1247
>                 URL: https://issues.apache.org/jira/browse/TEZ-1247
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.4.0
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: Tez-1247.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to