[
https://issues.apache.org/jira/browse/TEZ-1247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056298#comment-14056298
]
Jeff Zhang commented on TEZ-1247:
---------------------------------
[~bikassaha] I attach a new patch which move the processDAG logic out of
verify. In this way I could reuse the code of generating dot file, otherwise
even the dry-run still has the issue. What do you think ?
Changes in this patch:
* move processDAG out of verify, put it upfront rather delay it to last step.
This makes the verify method more clear in what it should do. ( all the
process logic is due to VertexGroup and GroupInputEdge, so put all the process
logic into where GroupInputEdge is added and the output is added to
VertexGroup, the vertex set in VertexGroup and GroupInputEdge is immutable, so
put these change upfront is OK )
* Enhance the TestDAGVerify to ensure that verify could been called multiple
times
> Method verify() of DAG can't been called multiples times in some cases
> ----------------------------------------------------------------------
>
> Key: TEZ-1247
> URL: https://issues.apache.org/jira/browse/TEZ-1247
> Project: Apache Tez
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Jeff Zhang
> Assignee: Jeff Zhang
> Attachments: Tez-1247-2.patch, Tez-1247.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
