[
https://issues.apache.org/jira/browse/TEZ-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062483#comment-14062483
]
Bikas Saha commented on TEZ-1266:
---------------------------------
Is edgemanager descriptor @nullable?
{code}+ public EdgeProperty
createDefaultCustomEdgeProperty(EdgeManagerDescriptor edgeManagerDescriptor) {
+ EdgeProperty edgeProperty ={code}
Is the partitioner name @nullable? If not, then there should be a Precondition
check somewhere that its not null. There was a test that was checking that
output partitioner must be specified but that test has been removed in this
patch. If partitioner must be specified in the constructor then we should test
for that and add a precondition.
rest looks ok.
> Consider creating
> UnorderedUnpartitionedKVEdgeConfiguration.createDefaultCustomEdge()
> -------------------------------------------------------------------------------------
>
> Key: TEZ-1266
> URL: https://issues.apache.org/jira/browse/TEZ-1266
> Project: Apache Tez
> Issue Type: Sub-task
> Reporter: Bikas Saha
> Assignee: Siddharth Seth
> Attachments: TEZ-1266.1.txt
>
>
> Reference
> https://issues.apache.org/jira/browse/TEZ-1080?focusedCommentId=14054194&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14054194
> from TEZ-1080
> cc [~sseth]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
