zrhoffman commented on code in PR #7615: URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1273678837
########## experimental/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html: ########## @@ -0,0 +1,45 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<mat-card appearance="outlined" class="page-content single-column"> + <tp-loading *ngIf="!topology"></tp-loading> + <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="topology"> + <mat-card-content class="container"> + <mat-form-field> + <mat-label>Name</mat-label> + <input matInput type="text" name="name" required readonly disabled [(ngModel)]="topology.name"> + </mat-form-field> + <mat-form-field *ngIf="!new"> + <mat-label>Description</mat-label> + <textarea matInput name="description" [(ngModel)]="topology.description"></textarea> + </mat-form-field> + </mat-card-content> + <mat-card-content class="container"> + <mat-tree [dataSource]="topologySource" [treeControl]="topologyControl"> + <mat-nested-tree-node *matTreeNodeDef="let node; when: hasChild"> + <div class="mat-tree-node" matTreeNodeToggle mat-menu-item [attr.aria-label]="'Toggle ' + node.name"> + {{node.name}} + </div> + <div class="expand-node" role="group"> + <ng-container matTreeNodeOutlet></ng-container> + </div> + <!--<mat-divider *ngIf="(node)"></mat-divider>--> Review Comment: Unused line removed ########## experimental/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html: ########## @@ -0,0 +1,45 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<mat-card appearance="outlined" class="page-content single-column"> + <tp-loading *ngIf="!topology"></tp-loading> + <form ngNativeValidate (ngSubmit)="submit($event)" *ngIf="topology"> + <mat-card-content class="container"> + <mat-form-field> + <mat-label>Name</mat-label> + <input matInput type="text" name="name" required readonly disabled [(ngModel)]="topology.name"> Review Comment: Using `[value]` now ########## experimental/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html: ########## @@ -0,0 +1,45 @@ +<!-- +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +--> +<mat-card appearance="outlined" class="page-content single-column"> + <tp-loading *ngIf="!topology"></tp-loading> Review Comment: Changed to ```html <tp-loading *ngIf="loading"></tp-loading> ``` but it's worth noting that a lot of code got merged that does the thing you want to avoid: ``` $ git grep '<tp-loading' src/app/core | grep -v '"loading"' src/app/core/cache-groups/asns/detail/asn-detail.component.html: <tp-loading *ngIf="!asn"></tp-loading> src/app/core/cache-groups/cache-group-details/cache-group-details.component.html: <tp-loading *ngIf="!cacheGroup"></tp-loading> src/app/core/cache-groups/coordinates/detail/coordinate-detail.component.html: <tp-loading *ngIf="!coordinate"></tp-loading> src/app/core/cache-groups/divisions/detail/division-detail.component.html: <tp-loading *ngIf="!division"></tp-loading> src/app/core/cache-groups/regions/detail/region-detail.component.html: <tp-loading *ngIf="!region"></tp-loading> src/app/core/cdns/cdn-detail/cdn-detail.component.html: <tp-loading *ngIf="!cdn"></tp-loading> src/app/core/parameters/detail/parameter-detail.component.html: <tp-loading *ngIf="!parameter"></tp-loading> src/app/core/servers/capabilities/capability-details/capability-details.component.html: <tp-loading *ngIf="!capability"></tp-loading> src/app/core/servers/phys-loc/detail/phys-loc-detail.component.html: <tp-loading *ngIf="!physLocation"></tp-loading> src/app/core/servers/server-details/server-details.component.html: <tp-loading *ngIf="!server"></tp-loading> src/app/core/types/detail/type-detail.component.html: <tp-loading *ngIf="!type"></tp-loading> src/app/core/users/roles/detail/role-detail.component.html: <tp-loading *ngIf="!role"></tp-loading> src/app/core/users/tenants/tenant-details/tenant-details.component.html: <tp-loading *ngIf="!tenant"></tp-loading> src/app/core/users/user-details/user-details.component.html: <tp-loading *ngIf="!user"></tp-loading> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
