ocket8888 commented on code in PR #7615:
URL: https://github.com/apache/trafficcontrol/pull/7615#discussion_r1276419142
##########
experimental/traffic-portal/src/app/core/core.module.ts:
##########
@@ -116,6 +116,7 @@ export const ROUTES: Routes = [
{ component: ProfileDetailComponent, path: "profiles/:id"},
{ component: ProfileTableComponent, path: "profiles"},
{ component: TopologyDetailsComponent, path: "topologies/:name"},
+ { component: TopologyDetailsComponent, path: "topologies-new"},
Review Comment:
we have `new-role` and `new-capability`. We don't have rules for how to
write the routes, and technically anything unique will work, but I'd suggest
sticking with the phonetic kebab-case statement of purpose, so people know at a
glance what a link is gonna take them to.
##########
experimental/traffic-portal/src/app/api/topology.service.spec.ts:
##########
@@ -0,0 +1,70 @@
+/**
Review Comment:
The coverage provided by this spec is
| Statements | Branches | Functions | Lines |
|------------------|---------------|----------------|-----------|
| 42.55% | 27.27% | 37.5% | 41.3% |
but it _should_ be
| Statements | Branches | Functions | Lines |
|------------------|---------------|----------------|-----------|
| 100% | 100% | 100% | 100% |
like (most of) the other API services
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
