Github user smalenfant commented on the issue:

    https://github.com/apache/incubator-trafficcontrol/pull/616
  
    That's what I was thinking about first time I looked at this. Not sure why
    we needed to iterate all the slaves. We can put this through the test, but
    it looks good to me.
    
    On Thu, May 25, 2017 at 3:09 PM, Jeff Elsloo <notificati...@github.com>
    wrote:
    
    > @smalenfant <https://github.com/smalenfant> can you take a look at this
    > PR and maybe give it a quick test? John and I had a chat about the
    > implementation and it seemed like removing the part that finds individual
    > interfaces was unnecessary. I'd like a second opinion to validate our
    > assumptions.
    >
    > John said he tested on 7.2 and 7.3 and didn't see any issues; bonded and
    > non-bonded interfaces.
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > 
<https://github.com/apache/incubator-trafficcontrol/pull/616#issuecomment-304096993>,
    > or mute the thread
    > 
<https://github.com/notifications/unsubscribe-auth/ADoJyEbN38oekoxGyn9Rw-Nm9Hbe4kjfks5r9dIEgaJpZM4Nmv7Q>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to