Github user mitchell852 commented on a diff in the pull request:
https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r129937865
--- Diff: traffic_ops/app/lib/API/DeliveryServiceUser.pm ---
@@ -31,6 +32,18 @@ sub delete {
return $self->forbidden();
}
+ my $user = $self->db->resultset('TmUser')->find( { id => $user_id } );
--- End diff --
i feel like there is no harm in checking tenancy on both the user and the
DS.
if i am trying to remove DS1 from user1 first check that user1 has a tenant
inside my tenant tree and then check that DS1 has a tenant in my tenant tree.
if DS1 is not inside my tenant tree, i should know NOTHING about that DS.
to me, that DS does not exist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
