Github user mitchell852 commented on a diff in the pull request:

    
https://github.com/apache/incubator-trafficcontrol/pull/753#discussion_r131253207
  
    --- Diff: traffic_ops/app/lib/API/User.pm ---
    @@ -376,6 +387,10 @@ sub get_deliveryservices_not_assigned_to_user {
     
        my $rs_links = $self->db->resultset("Deliveryservice")->search( undef, 
{ order_by => "xml_id" } );
        while ( my $row = $rs_links->next ) {
    +           if 
(!$tenant_utils->is_ds_resource_accessible_to_tenant($tenants_data, 
$row->tenant_id, $user->tenant_id)) {
    --- End diff --
    
    when assigning ds's to a user, the ds's should be limited to those in the 
current user's tenant tree, right? so yes, i think you should be checking the 
tenancy of the current user.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to